-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filter)!: new simpler filter API #2092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
danisharora099
force-pushed
the
feat/filter-api-refactor
branch
2 times, most recently
from
July 31, 2024 09:33
efed717
to
975792c
Compare
size-limit report 📦
|
adklempner
approved these changes
Jul 31, 2024
danisharora099
force-pushed
the
feat/filter-api-refactor
branch
from
August 1, 2024 09:50
975792c
to
d9a5e4d
Compare
39 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Based on the Reliability Epic, we want:
This also ties in with #2022, where Filter API is hard-to-understand, and involves multiple steps:
Solution
Based on the fact that
decoder
has information about thepubsubTopic
as well ascontentTopic
, we can usedecoders
to fetch information about both the topics, and API can be condenses into:Notes
filter.subscribe()
dependency onIReceiver
#1979, whereIReceiver
dependency is renamed tosubscribeWithFilter
instead, andsubscribe()
is brought out as the primary API (feat: removefilter.subscribe()
dependency onIReceiver
#1979 (comment))Contribution checklist:
!
in title if breaks public API;